VideoBackends: Share GX vertex/index/uniform buffers with utility draws #7592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, had a quick look through each commit and couldn't find much else to say other than "amazing refactoring" :) Given this is a decently large change, I'm tempted to wait 2 days and merge it after beta is tagged. Your thoughts? |
|
Sounds fine to me. There is one path I haven't tested (drivers which don't support base_vertex). While I don't see any reason it should regress, I probably should check it just in case. |
|
Could you fix the merge conflict? Thanks! |
Since we use the common pipelines here and draw vertices if a batch is currently being built by the vertex loader, we end up trampling over its pointer, as we share the buffer with the loader, and it has not been unmapped yet. Force a pipeline flush to avoid this.
weihuoya
reviewed
Dec 4, 2018
| g_renderer->SetPipeline(m_current_pipeline_object); | ||
| Draw(stride); | ||
| static_cast<Renderer*>(g_renderer.get())->SetPipeline(m_current_pipeline_object); | ||
| static_cast<Renderer*>(g_renderer.get())->DrawIndexed(base_index, num_indices, base_vertex); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a prerequisite for our imgui integration. It makes VertexManager a little more generic, moving some of the logic into common, and enabling buffer sharing with utility shader draws (used for imgui).
In the future, we can also use this for drawing EFB copies, and post-processing, rather than having all these different buffers sitting around the place (and duplicated across the backends). This is mainly the case in Vulkan, not so much in the others.